Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch: 4.9.x (but I think it can be merged in upper versions)
Resolves issue #393
Current
CheckOrigin
class checks that origin is a valid URL and either the facetID or a subdomain of the facetID. But it seems that native application origins are not supported (parse_url
would not provide ahost
section).Thus, we suggest to simply check that this kind of origins must be in the securedRelyingPartyId whitelist.
This is based on https://www.w3.org/TR/webauthn-3/#sctn-validating-origin and more specifically this example: