Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check origin #686

Open
wants to merge 1 commit into
base: 4.9.x
Choose a base branch
from

Conversation

Tithugues
Copy link

Target branch: 4.9.x (but I think it can be merged in upper versions)
Resolves issue #393

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

Current CheckOrigin class checks that origin is a valid URL and either the facetID or a subdomain of the facetID. But it seems that native application origins are not supported (parse_url would not provide a host section).

Thus, we suggest to simply check that this kind of origins must be in the securedRelyingPartyId whitelist.

This is based on https://www.w3.org/TR/webauthn-3/#sctn-validating-origin and more specifically this example:

A web application with a companion native application might allow origin to be an operating system dependent identifier for the native application. For example, such a Relying Party might require that origin exactly equals some element of the list ["https://example.org", "example-os:appid:204ffa1a5af110ac483f131a1bef8a841a7adb0d8d135908bbd964ed05d2653b"].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant